search

django-commons / drf-excel

An XLSX spreadsheet renderer for Django REST Framework.
BSD 3-Clause "New" or "Revised" License
217 stars 40 forks source link

Added iterables in flatten to item list #11

Closed frruit closed 5 years ago

frruit commented 5 years ago

From my viewpoint it's required to return lists also as a separated list.

If possible please take the change to next release so that i can use it via pip in my project :-)

FlipperPA commented 5 years ago

I'm going to tweak this slightly, to create two separators. I just want to be sure we're not relying on the "." separator anywhere else in the code.

FlipperPA commented 5 years ago

@frruit Would you like me to add your name to the Contributors, or just ffruit?

FlipperPA commented 5 years ago

@frruit I've merged the changed and tweaks to master. Can you test off the master branch and make sure this works as your expected? I added a second separator for lists, so we don't affect the existing behavior for other data types. If it is all good, I'll get this released to PyPI.

frruit commented 5 years ago

@FlipperPA if you want then please add me as a contributor. My name is Franjo Rupcic and thanks for the offer.

I cannot test it currently because i'm on vacation and my laptop is not with me. From my viewpoint you can release it because it's enhancement but i'll give you more feedback when i'm start to work again with it. At the moment I think that the user of you mixin class should be able to overwrite the seperator from outside the library. Something like the configuration of the filename via the mixin class.