search

django-commons / drf-excel

An XLSX spreadsheet renderer for Django REST Framework.
BSD 3-Clause "New" or "Revised" License
217 stars 40 forks source link

write array of array as json #13

Closed willtho89 closed 5 years ago

willtho89 commented 5 years ago

this is basically a workaround if someone uses nested fields (e.g. HyperlinkWrapperField()) and doesn't want to use a different serializer for xlsx export.

This fix prevents a TypeError on items.append((new_key, list_sep.join(v)))

FlipperPA commented 5 years ago

This looks good to me, thanks for the contribution. I'll be looking at the other PR shortly!

FlipperPA commented 5 years ago

Both PRs have been merged and released as 0.3.4: https://pypi.org/project/drf-renderer-xlsx/0.3.4/

Thanks for the contribution, @willtho89!