Update openpyxl requirements to compatiblity fix

django-commons / drf-excel

An XLSX spreadsheet renderer for Django REST Framework.

BSD 3-Clause "New" or "Revised" License

217 stars 40 forks source link

Update openpyxl requirements to compatiblity fix #71

Closed TurnrDev closed 1 year ago

TurnrDev commented 1 year ago

drf_excel.renderers.XLSXRenderer uses openpyxl.writer.excel.save_virtual_workbook which has been deprecated since 2018 and removed in openpyxl 3.1.0

This is a temporary fix to solve dependency issues, but a proper fix should be to not use save_virtual_workbook

alb3rto269 commented 1 year ago

Thanks for this PR.

I also created https://github.com/wharton/drf-excel/pull/72 with a proposal to remove the deprecated dependency.

FlipperPA commented 1 year ago

Thanks for the PR, @TurnrDev - it is appreciated! I'm going to close this in lieu of #72, from @alb3rto269, which gives us compatibility with OpenPyXL 3.10+.

TurnrDev commented 1 year ago

Understand, #72 is definitely a better PR! Will that be released soon? 😊