search

django-commons / drf-excel

An XLSX spreadsheet renderer for Django REST Framework.
BSD 3-Clause "New" or "Revised" License
217 stars 40 forks source link

Support nullable ListFields with django-rest-framework #78

Closed Rmvandiepen closed 2 weeks ago

Rmvandiepen commented 1 year ago

As mentioned in https://github.com/wharton/drf-excel/issues/61 it doesn't work when a ListField has a null value in it. This should fix that 🥳

FlipperPA commented 1 year ago

@Rmvandiepen Hey, I very much appreciate the PR! I'm hoping to take some time at DjangoCon US this week during sprints to catch up on merges. Didn't want you to think I was ignoring you!

FlipperPA commented 4 months ago

@rptmat57 @melvinkcx This is a PR for NULL fields. I'm pretty sure we still need to merge this one to cover all edge cases, but wanted to run it by both of you since you encountered and fixed the edge case from yesterday. Thoughts?

rptmat57 commented 4 months ago

same, looks good!

codecov-commenter commented 2 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@339e088). Learn more about missing BASE report.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #78 +/- ## ======================================= Coverage ? 92.87% ======================================= Files ? 4 Lines ? 351 Branches ? 0 ======================================= Hits ? 326 Misses ? 25 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

browniebroke commented 2 weeks ago

Thanks a lot for your contribution and your patience 🎉