search

django-commons / drf-excel

An XLSX spreadsheet renderer for Django REST Framework.
BSD 3-Clause "New" or "Revised" License
217 stars 40 forks source link

Fix Django classifiers #97

Closed browniebroke closed 2 weeks ago

browniebroke commented 2 weeks ago

Getting an error when trying to upload as it stands:

ERROR HTTPError: 400 Bad Request from https://upload.pypi.org/legacy/
'Framework :: Django :: 5' is not a valid classifier. See https://packaging.python.org/specifications/core-metadata for more information.

Looks like we need to specify the major and minor versions now: https://pypi.org/classifiers/

codecov-commenter commented 2 weeks ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (main@a14f81d). Learn more about missing BASE report.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #97 +/- ## ======================================= Coverage ? 92.87% ======================================= Files ? 4 Lines ? 351 Branches ? 0 ======================================= Hits ? 326 Misses ? 25 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

FlipperPA commented 2 weeks ago

We missed adding the trove classifier for Django 5, that exists for prior releases. I've issued a PR: https://github.com/pypa/trove-classifiers/compare/main...FlipperPA:trove-classifiers:patch-2

They're normally pretty fast!

browniebroke commented 2 weeks ago

I thought that was done on purpose, Django doesn't strictly follows semver, and there might be some breaking changes in minor releases. A package running in version X.Y is not guaranteed to work with X.Y+1

FlipperPA commented 2 weeks ago

Since before my time, Django has always had trove classifiers for major versions (you can see they exist for version 1, 2, 3, and 4). Breaking changes in minor releases are fairly rare in packages, and I think have the major release classifiers allows for a bit less churn in packages, just to update their classifiers. Maybe that has changed, but I didn't see any discussion - I guess we'll see if there's any comment on the PR. 😄