search

django-compressor / django-appconf

An app to handle configuration defaults of packaged Django apps gracefully
https://django-appconf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
350 stars 47 forks source link

Update install_requires Django version #68

Closed CleitonDeLima closed 4 years ago

CleitonDeLima commented 4 years ago

It is a good practice to specify the version of the dependencies https://packaging.python.org/discussions/install-requires-vs-requirements/#install-requires

:smiley:

carltongibson commented 4 years ago

Thanks for the thought though.

bwh1te commented 3 years ago

FYI the current unpinned dependency acts like this with up-to-date pip-tools and pip:


Collecting django[argon2]==2.2.14  <-- look, we already have Django installed after this
  Using cached Django-2.2.14-py3-none-any.whl (7.5 MB)
...
Collecting django  <-- django-appconf forces us to install one more Django version (the latest one)
ERROR: In --require-hashes mode, all requirements must have their versions pinned with ==. These do not:
    django from https://files.pythonhosted.org/packages/89/69/c556b5b3e7a6701724485fc07c8349791e585b784dc70c9c0683d98ef0db/Django-3.2.3-py3-none-any.whl#sha256=7e0a1393d18c16b503663752a8b6790880c5084412618990ce8a81cc908b4962 (from django-appconf==1.0.4->-r requirements/base.txt (line 167))```