django-compressor / django-appconf

An app to handle configuration defaults of packaged Django apps gracefully
https://django-appconf.readthedocs.io
BSD 3-Clause "New" or "Revised" License
350 stars 47 forks source link

1.0.4 wheel erroneously says that it supports Py2 #71

Closed native-api closed 3 years ago

native-api commented 4 years ago

At https://travis-ci.community/t/syntaxerror-fails-ci-build-in-appconf-instantiation-with-metaclass/8351, a user reported a problem that resulted from trying to run 1.0.4 in Py2.

However, if that version doesn't support Py2, it shouldn't have been installed in the first place.

It turns out that the wheel's name and its metadata by which Pip picks wheels (WHEEL in particular) still erroneously says that it supports Py2.

siovene commented 3 years ago

I have the same problem, upgrading from 1.0.2 to 1.0.4 broke my build as follows:

File "/usr/local/lib/python2.7/dist-packages/appconf/base.py", line 107
--
978 | class AppConf(metaclass=AppConfMetaClass):
979 | ^
980 | SyntaxError: invalid syntax

Is it possible to maintain Python 2 support? Or at least, not break it on a patch-level release? :)

Thank you!