django-crispy-forms / crispy-bootstrap5

Bootstrap5 template pack for django-crispy-forms
MIT License
462 stars 76 forks source link

Fix the headers of table_inline_formset.html do not display correctly #140

Closed blasferna closed 1 year ago

blasferna commented 1 year ago

The headers of the table do not display correctly using the table_inline_formset.html template to render a inline formset

Before

imagen

After

imagen

fix #139

smithdc1 commented 1 year ago

Thanks for the patch.

Could you add a small test? A minimal layout could be created with the output asserted something like this.

https://github.com/django-crispy-forms/crispy-bootstrap5/blob/94f0ca5adbe528b7ea43ab8238e4adc849ae84a3/tests/test_layout_objects.py#L366

blasferna commented 1 year ago

Can I edit the existing test for bootstrap5/table_inline_formset.html? Because I see that it fails with the changes I have introduced in this pull request. Or would you prefer a new test?

smithdc1 commented 1 year ago

Yes. Fixing the failing test would be great.

Hopefully the tests run this time when you push the changes. 🤞

smithdc1 commented 1 year ago

Thank you! 🥇