search

django-crispy-forms / crispy-bootstrap5

Bootstrap5 template pack for django-crispy-forms
MIT License
462 stars 76 forks source link

fix: fix formactions template to consider arguments #144

Closed mschoettle closed 1 month ago

mschoettle commented 1 year ago

Adds id and css_class to the div. Also adds row to the class if the form is supposed to be horizontal.

I removed the inner divs since those seemed to be not used. Let me know if that is incorrect.

Also, let me know if I should add tests for this.

Fixes #143

JanMalte commented 1 year ago

@smithdc1 could this please be merged and a bugfix version be released soon?

smithdc1 commented 1 year ago

Hi All,

I'd like to see a small test added as that seems to be missing at the moment. A minimal layout could be created with the output asserted something like this.

https://github.com/django-crispy-forms/crispy-bootstrap5/blob/94f0ca5adbe528b7ea43ab8238e4adc849ae84a3/tests/test_layout_objects.py#L366

smithdc1 commented 1 year ago

@JanMalte -- do you have time to add a test for this?

mschoettle commented 1 year ago

Sorry for the delay. I agree that tests would be good so I finally added some.

mschoettle commented 1 year ago

@smithdc1 Brought this PR up to date with main. Could you please re-review?

mschoettle commented 8 months ago

@smithdc1 I addressed the requested changes. Could you please look at this again?

mschoettle commented 1 month ago

@smithdc1 Any chance you could re-review this?

smithdc1 commented 1 month ago

Thanks for the ping. This looks good to me

One final question -- do you think this needs an entry in the changelog?

smithdc1 commented 1 month ago

Added release note in #187