django-crispy-forms / crispy-tailwind

A Tailwind template pack for django-crispy-forms
MIT License
331 stars 56 forks source link

pin requirements #105

Closed chriswedgwood closed 2 years ago

chriswedgwood commented 2 years ago

This wil resolve #104

The issue was with sphinx-rtd-theme. Its latest version requires docutils < 0.17

sphinx-rtd-theme==0.5.1 does not raise an error

codecov-commenter commented 2 years ago

Codecov Report

Merging #105 (de638f2) into main (2ff9135) will increase coverage by 11.30%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #105       +/-   ##
===========================================
+ Coverage   71.11%   82.41%   +11.30%     
===========================================
  Files          37       37               
  Lines         637      637               
  Branches       28       28               
===========================================
+ Hits          453      525       +72     
+ Misses        174      102       -72     
  Partials       10       10               
Impacted Files Coverage Δ
...lwind/templates/tailwind/table_inline_formset.html 98.11% <0.00%> (+1.88%) :arrow_up:
...tailwind/templates/tailwind/whole_uni_formset.html 78.57% <0.00%> (+3.57%) :arrow_up:
...py_tailwind/templates/tailwind/whole_uni_form.html 100.00% <0.00%> (+7.69%) :arrow_up:
crispy_tailwind/templates/tailwind/uni_form.html 100.00% <0.00%> (+10.00%) :arrow_up:
crispy_tailwind/tailwind.py 96.87% <0.00%> (+21.87%) :arrow_up:
crispy_tailwind/templatetags/tailwind_field.py 83.48% <0.00%> (+34.86%) :arrow_up:
crispy_tailwind/templatetags/tailwind_filters.py 61.53% <0.00%> (+44.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2ff9135...de638f2. Read the comment docs.

chriswedgwood commented 2 years ago

In general I like to keep the dev dependencies unpinned, unless one is creating a specific problem (like here).

I then pin that one, with a link to a tracking issue upstream, so that it's easy to check if it can be unpinned yet.

You get the odd breakage this way, but it serves as a notification of upstream issues, and it stops you hitting an unexpected (hard) break when the deps haven't been touched for two years and suddenly you have a lot of work to do.

Does that make sense?

Yes that makes , I wasn't sure if what I was doing was good practice or not. Will update PR

smithdc1 commented 2 years ago

Thank you Chris! 👍