search

django-crispy-forms / crispy-tailwind

A Tailwind template pack for django-crispy-forms
MIT License
329 stars 56 forks source link

Fix: Select attributes are leak to option children #133

Closed hongquan closed 4 months ago

hongquan commented 1 year ago

Currently, if we pass extra attrs to Select, they are unexpectly copied to <option> children. This breaks our integration with AlpineJS:

image

hongquan commented 1 year ago

CI is failing but those issues are not related to this PR.

hongquan commented 11 months ago

@smithdc1 Could you take a look?

smithdc1 commented 11 months ago

Can you rebase to main. Hopefully tests will then pass. 👍

hongquan commented 11 months ago

@smithdc1 The CI does not automatically run.

codecov-commenter commented 11 months ago

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (382611b) 88.20% compared to head (b1527b2) 88.20%.

:exclamation: Current head b1527b2 differs from pull request most recent head cb9562c. Consider uploading reports for the commit cb9562c to get more accurate results

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #133 +/- ## ======================================= Coverage 88.20% 88.20% ======================================= Files 37 37 Lines 636 636 Branches 28 28 ======================================= Hits 561 561 Misses 66 66 Partials 9 9 ``` | [Files Changed](https://app.codecov.io/gh/django-crispy-forms/crispy-tailwind/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [...lwind/templates/tailwind/layout/select\_option.html](https://app.codecov.io/gh/django-crispy-forms/crispy-tailwind/pull/133?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-Y3Jpc3B5X3RhaWx3aW5kL3RlbXBsYXRlcy90YWlsd2luZC9sYXlvdXQvc2VsZWN0X29wdGlvbi5odG1s) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hongquan commented 4 months ago

Superseded by https://github.com/django-crispy-forms/crispy-tailwind/pull/150.