search

django-crispy-forms / crispy-tailwind

A Tailwind template pack for django-crispy-forms
MIT License
329 stars 56 forks source link

#118: Added missing "disabled" attribute to select template #146

Closed GitRon closed 6 months ago

GitRon commented 6 months ago

Partially addresses issue https://github.com/django-crispy-forms/crispy-tailwind/issues/118 and supersedes PR https://github.com/django-crispy-forms/crispy-tailwind/pull/120.

GitRon commented 6 months ago

@carltongibson As promised, I started fixing bugs 🙃

GitRon commented 6 months ago

@carltongibson Fixed the pipeline here as well. Would be happy to get a quick review.

carltongibson commented 6 months ago

@GitRon LGTM. Press on! 😅

I might have to review in batch if you're too quick 😜 — But we can always fix things/nothing really will break 🥰

GitRon commented 6 months ago

That's true! I think having a release and then go through the open issues and PRs should take some time but then we should have a clean slate again.

carltongibson commented 6 months ago

Sounds like a plan. If you can line up a release (or as close as possible) and we'll see if we can't push it out the door.

(He says, noting to himself, that likely @smithdc1 is on the hook for it 😜)