search

django-crispy-forms / crispy-tailwind

A Tailwind template pack for django-crispy-forms
MIT License
329 stars 56 forks source link

DIV for select box not terminated #156

Closed dpjanes closed 4 months ago

dpjanes commented 4 months ago

In templates/tailwind/field.html none of the divs are terminated (for release 1.0.1),

I think there's some mismatch between how you are doing it in the layout folder and in this template - I suspect it makes more sense to move all the closing DIVs back up to this file. In the select.html there is no </div> whereas I think in the radio and checkboxes there are.

dpjanes commented 4 months ago

Basically at this point, crispy-tailwind will not work for <select> any more! So pretty serious.

justinmayer commented 4 months ago

Hey David. I can't test this right now, but if this is indeed an issue, then I am fairly certain that it is a duplicate of #153, so let's continue the discussion there.

As an aside, it's always helpful to check open PRs before filing new issues. Thanks! 😊

dpjanes commented 4 months ago

My apologies, I did look but obviously I am blind!