search

django-crispy-forms / crispy-tailwind

A Tailwind template pack for django-crispy-forms
MIT License
329 stars 56 forks source link

Update field.html #165

Closed IsraelBO17 closed 2 months ago

IsraelBO17 commented 2 months ago

There's no use of the field_class variable that carries the 'mb-0' class. If there is, please explain

smithdc1 commented 2 months ago

Thanks for the PR.

I'm slightly unsure what issue this aims to fix? It would be helpful if you could explain this.

Also please do run the test suite -- there's a number of errors shown with this change. We would need to be mindful of backward compatability.

IsraelBO17 commented 2 months ago

Good day Smith, Pardon my negligence, I'm a newbie in Django and I was trying to get rid of the mb-3 class that was added their under the field_class if else block. Maybe you could explain how I can go about that. Thank you

On Tue, Apr 30, 2024, 8:55 PM David Smith @.***> wrote:

Thanks for the PR.

I'm slightly unsure what issue this aims to fix? It would be helpful if you could explain this.

Also please do run the test suite -- there's a number of errors shown with this change. We would need to be mindful of backward compatability.

— Reply to this email directly, view it on GitHub https://github.com/django-crispy-forms/crispy-tailwind/pull/165#issuecomment-2086950159, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYNNOAHIA2WYVK46WARYGOLY77ZJTAVCNFSM6AAAAABHAZU3LWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBWHE2TAMJVHE . You are receiving this because you authored the thread.Message ID: @.***>

smithdc1 commented 2 months ago

To make this type of customisation I recommend creating your own custom version of this template in your project.

You can then set the field_template attribute on your helper to use it throughoutyour project. See docs. https://django-crispy-forms.readthedocs.io/en/latest/form_helper.html#helper-attributes-you-can-set

smithdc1 commented 2 months ago

I'm not sure if there's a better way to handle this as an option. We get similar requests on the bootstrap5 pack.

However, just removing the margin isn't an acceptable solution as it seems to work for many situations.