django-crispy-forms / crispy-tailwind

A Tailwind template pack for django-crispy-forms
MIT License
356 stars 57 forks source link

set selected for option with field value #52

Closed shabinesh closed 4 years ago

shabinesh commented 4 years ago

Select field is not selected if the field value exists.

Thanks for working on this package :)

codecov-commenter commented 4 years ago

Codecov Report

Merging #52 into master will increase coverage by 1.16%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
+ Coverage   60.91%   62.08%   +1.16%     
==========================================
  Files          36       36              
  Lines         637      625      -12     
  Branches       28       28              
==========================================
  Hits          388      388              
+ Misses        239      227      -12     
  Partials       10       10              
Impacted Files Coverage Δ
...lwind/templates/tailwind/layout/select_option.html 100.00% <ø> (ø)
crispy_tailwind/templatetags/tailwind_filters.py 17.64% <0.00%> (+0.33%) :arrow_up:
crispy_tailwind/templatetags/tailwind_field.py 51.02% <0.00%> (+5.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6f2e191...8ac6a12. Read the comment docs.

smithdc1 commented 4 years ago

@shabinesh Thanks for this! 🚀 I made a couple of minor white space amends and pushed a test.

Any other comments / feedback would be much appreciated 👍.

Also- hello codecov, you have returned!