django-crispy-forms / crispy-tailwind

A Tailwind template pack for django-crispy-forms
MIT License
331 stars 56 forks source link

Ensure code style is properly checked by Flake8 #70

Closed justinmayer closed 3 years ago

justinmayer commented 3 years ago

I made these changes before noticing #34 and realizing the obvious overlap. The main difference between this PR and the changes in #34 is that this PR does not attempt to re-indent the HTML tags in tests/test_filter.py, and the two spurious spaces inside the checkboxinput class are for the moment left as-is.

I know within the other PR @smithdc1 expressed a desire to split the above test into smaller pieces, but for the moment I suggest applying these changes first and then addressing the test-splitting endeavor in a subsequent task. That way at least any near-term commits to the project will be properly checked for code style, with any violations caught via CI.

Just my two cents, of course. I hope this is helpful. 💫