search

django-crispy-forms / crispy-tailwind

A Tailwind template pack for django-crispy-forms
MIT License
331 stars 56 forks source link

Fix unclosed <div> for non-field errors #77

Closed gigincg closed 3 years ago

gigincg commented 3 years ago

Solves #76

smithdc1 commented 3 years ago

@gigincg -- thanks for this. Unfortunately, the tests are failing as they are missing the new closing div

gigincg commented 3 years ago

@smithdc1 I see that the tests are failing. I'm not an expert in Django, any chance you can shed some light on whatsa actually going wrong?

codecov-io commented 3 years ago

Codecov Report

Merging #77 (a2873a8) into master (1349fd7) will increase coverage by 0.04%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   70.70%   70.75%   +0.04%     
==========================================
  Files          36       36              
  Lines         635      636       +1     
  Branches       28       28              
==========================================
+ Hits          449      450       +1     
  Misses        176      176              
  Partials       10       10
Impacted Files Coverage Δ
crispy_tailwind/templates/tailwind/errors.html 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1349fd7...a2873a8. Read the comment docs.

smithdc1 commented 3 years ago

Thanks, @gigincg -- we just needed to add the new closing div to the relevant test.