search

django-crispy-forms / crispy-test-project

Simple Django project for testing https://github.com/maraujop/django-crispy-forms based on https://gist.github.com/maraujop/1838193
https://crispy-test-project.herokuapp.com
9 stars 12 forks source link

Example html code #15

Open smithdc1 opened 4 years ago

smithdc1 commented 4 years ago

Hi @django-crispy-forms/core-team

I'm wondering if it's worth us putting the html being generated by the latest release of django-crispy-forms into this repo? And maybe serve it through gh pages?

My thinking is that it could be useful to see the html 'a clean' project created. It would be helpful to assess issues raised as we can compare expected Vs experienced? Having to load the project up to do this is a bit of a pain?

bryan-brancotte commented 4 years ago

I think it could be a good idea, from https://github.com/JamesIves/github-pages-deploy-action I understand that we could push on a dedicated branch html file produced rendered by a temporary django server, and then configure pages to server on this branch.

smithdc1 commented 4 years ago

Hi Bryan,

That sounds like a great idea. I'll investigate and get back to you.

Wonder if we could do something with PR's on the main repo too......

On Thu, 24 Oct 2019, 12:16 bryan brancotte, notifications@github.com wrote:

I think it could be a good idea, from https://github.com/JamesIves/github-pages-deploy-action I understand that we could push on a dedicated branch html file produced rendered by a temporary django server, and then configure pages to server on this branch.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/django-crispy-forms/crispy-test-project/issues/15?email_source=notifications&email_token=AJM6IOQYH4CVXENNTN6SYMTQQF7YLA5CNFSM4JEPH3KKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECEVHEI#issuecomment-545870737, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJM6IOTKAWC5AVW4NIX4LYTQQF7YLANCNFSM4JEPH3KA .

bryan-brancotte commented 4 years ago

Indeed It could also be nice, but I am wondering the amout of time we will use to set it up compared to its utility. Never the less, the initial idea of having it as a showroom of what crispy does is nice.

bryan-brancotte commented 4 years ago

In the case of a showroom, maybe #1 with heroku is still a valide solution

smithdc1 commented 4 years ago

Thanks for your link earlier. I've been doing some research.

Thoughts? Am I crazy!?

smithdc1 commented 4 years ago

So a little update on this. I have had a lot of fun trying to progress this over the last few days.

I've managed to build a tool which on push or on pull-request triggers the following

  1. build of a virtual environment
  2. runs the tests
  3. generates the crispy-test-project sites and saves the html
  4. an index.html page is built which links to all of the sites
  5. pushes to the gh-pages branch
  6. publish the website

Here is a link

The integration with the PR is also quite nice (here)[https://github.com/smithdc1/crispy-test-project/pull/5]. Please excuse the 'mess' of the change long, scroll to the bottom of the page (keep going).

However, there is a show stopper with this. It only works on PRs from the same repo. Currently the permissions fail (for security reasons) with a PR from a fork. Maybe in time GH will look to address this.

At least the journey was enjoyable.

ckrybus commented 1 year ago

Hi @smithdc1,

I've started working on a template pack overview site hosted on Github Pages. It's 70% done - it needs to be polished and a few template packs are missing/need to be cleaned up, it's more like a MVP right now, but you can see it already live here https://ckrybus.github.io/crispy-test-project/

How does it work?

The code is here https://github.com/django-crispy-forms/crispy-test-project/compare/main...ckrybus:crispy-test-project:main It includes also my PR https://github.com/django-crispy-forms/crispy-test-project/pull/33 which has been open for over a year.

Right now the header is template pack specific, later we could maybe make it an iframe toolbar or something so that it looks exactly the same for all pages, etc.

Ideally I would like to merge it with the crispy-test-project, the url would be then https://django-crispy-forms.github.io/crispy-test-project/.

1) Is it something you or the other maintainers are willing to merge (after it has been polished)? 2) Is this project still maintained / are you looking for maintainers? Bulma PR is open, I also saw that bootstrap5 is already implemented, it probably only needs to be a little updated.

smithdc1 commented 1 year ago

Hi @ckrybus

I think of this as a mini test project which folk can use to test their template packs. Having a branch on your fork seems the way to go rather than pushing those changes upstream? Likely your project will move at your own pace and I shouldn't be in the way of that?

ckrybus commented 1 year ago

I'm trying to create something like "djangopackages.org" for django-crispy-forms + preview functionality known from many template directories so I can compare the bulma template pack to others, but it is not bulma specific. In my opinion the main value is the template pack preview functionality, because probably something like 99% of django-crispy-forms users use an existing template pack. That said, while (re)writing crispy-bulma the crispy-test-project was indeed very helpful :+1:

So that's my goal. Then I will keep it in my repo for now. Thanks for the quick reply!