search

django-crispy-forms / django-crispy-forms

The best way to have DRY Django forms. The app provides a tag and filter that lets you quickly render forms in a div format while providing an enormous amount of capability to configure and control the rendered HTML.
http://django-crispy-forms.rtfd.org
MIT License
5.04k stars 734 forks source link

Drop Django 4.0 and 4.1. #1368

Closed smithdc1 closed 1 year ago

smithdc1 commented 1 year ago

As I understand it Django recomends dropping 4.1 upon release of 5.0. That's only a few weeks away now so I'm doing that now.

Maybe that's too early, but it's only really classifers that will change, it will still work as we still have dependencies = ["django>=3.2"].

If it's too early, we can just hold a release back a few weeks, there's not been any funcionality change since 2.0.

codecov-commenter commented 1 year ago

Codecov Report

Merging #1368 (93fdb0d) into main (4c5cea5) will not change coverage. The diff coverage is n/a.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/django-crispy-forms/django-crispy-forms/pull/1368/graphs/tree.svg?width=650&height=150&src=pr&token=BHskQXzRBL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)](https://app.codecov.io/gh/django-crispy-forms/django-crispy-forms/pull/1368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) ```diff @@ Coverage Diff @@ ## main #1368 +/- ## ======================================= Coverage 89.30% 89.30% ======================================= Files 12 12 Lines 1010 1010 Branches 192 192 ======================================= Hits 902 902 Misses 78 78 Partials 30 30 ``` | [Flag](https://app.codecov.io/gh/django-crispy-forms/django-crispy-forms/pull/1368/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/django-crispy-forms/django-crispy-forms/pull/1368/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `89.30% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more. ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/django-crispy-forms/django-crispy-forms/pull/1368?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/django-crispy-forms/django-crispy-forms/pull/1368?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Last update [4c5cea5...93fdb0d](https://app.codecov.io/gh/django-crispy-forms/django-crispy-forms/pull/1368?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None).
smithdc1 commented 1 year ago

It might be time to drop 3.2 as well.

Will think about this. 👍

uri-rodberg commented 1 year ago

If it's too early, we can just hold a release back a few weeks, there's not been any funcionality change since 2.0.

Personally I think it's too early. Django 4.1 and 3.2 are still supported (until December 2023 and April 2024 respectively). Actually I tried to upgrade all my packages with pip, and I was surprised to see that django-crispy-forms has been released but was not upgraded, until I found you dropped support for Django 3.2 and 4.1. Consider releasing a new version of django-crispy-forms supporting Django 3.2 and 4.1, which are still supported for the next 6 months (3.2). It's not common to drop support for a package that is still supported. But I don't mind using django-crispy-forms==2.0, which still supports Django 4.1, until the next time I upgrade Django. I just say it's not common to drop support for a supported package like this.

carltongibson commented 1 year ago

@uri-rodberg The existing version continues to work for you as-is. If you're not already on Django 4.2, updating Django is going to be of significantly more benefit than being on the latest crispy-forms.

This release is in preparation for Django 5.0, in pre-release now. When that's final 4.1 will be EOL, and the Django docs recommend dropping all support for Django<4.2 at that point. (That includes the not EOL Django 3.2.)

It's time to update.

Rather than sit on this release until 5.0 is final, just for the last moments of Django 4.1, it's better to release it now. Those on 4.1 just don't update. Everyone else gets the new version.

uri-rodberg commented 1 year ago

@carltongibson OK, I understand.