IMPROVEMENT: Django 4.0 breaks downloads

django-daiquiri / daiquiri

A framework for the publication of scientific databases

https://escience.aip.de/daiquiri

Apache License 2.0

26 stars 8 forks source link

IMPROVEMENT: Django 4.0 breaks downloads #105

Open andonij opened 2 years ago

andonij commented 2 years ago

The new django version 4 deprecates django.utils.http.urlquote and django.utils.encoding.force_text breaking downloads using django-sendfile.

The package seems to be unmantained, maybe change to django-sendfile2?

Solution is to manually change __init__.py file of the django-sendfile package:

from django.utils.encoding import force_unicode as force_text change to from django.utils.encoding import force_str as force_text
from django.utils.http import urlquote change to from urllib.parse import quote as urlquote

agy-why commented 1 year ago

Dear @andonij, thank you for your feed back!

As you may have seen in the newer release of daiquiri we indeed moved to django-sendfile2, however we are still not happy with this solution and we are looking for other alternatives. So this aspect of daiquiri will evolve in the near future, I'll keep you informed.

BTW, are you using dq-dev (docker) or are you running daiquiri directly in your OS?

In case you have issues in configuring your static file server, please let us know, we may be able to help.

I wish you a nice day.

andonij commented 1 year ago

Hi @agy-why

Currently using daiquiri directly with mariadb and apache (currently its more like an internal thing)

I will have to check the docker before deploying it officially. Thanks!