search

django-daiquiri / daiquiri

A framework for the publication of scientific databases
https://escience.aip.de/daiquiri
Apache License 2.0
25 stars 8 forks source link

BUG: spoint issues #162

Open agy-why opened 1 year ago

agy-why commented 1 year ago

It seems that spoints are not properly downloaded or uploaded. need further investigation.

I get a char(32) for spoint which is too small to properly describe the position (losing the second parenthesis.

agy-why commented 1 year ago

I could identify the issue coming from downloading. The generation of spoints fails in form of VOTable.

agy-why commented 1 year ago

The issue is due to the fact that the postgres spoint type is translated into char(32).

this is coming from the default datatype being char(32) see: daiquiri/core/adapter/database/postgres.py

agy-why commented 1 year ago

It seems that a solution could be to add a DATATYPE spoint in daiquiri/core/adapter/database/postgres.py

and check for () in https://github.com/django-daiquiri/daiquiri/blob/686352c80ad8d269c519b9d93f62e68cf874e625/daiquiri/core/adapter/database/postgres.py#L331 to identify spoint type rows.

agy-why commented 1 year ago

upload catching is solved but #160

Downloading still need to be solved

kimakan commented 5 months ago

The issue concerns all adql datatypes, such as CIRCLE, POLYGON, BOX, etc. we have to fix the issue ASAP in order to be compatible with ADQL. Otherwise, there is no way for the user to retrieve complete results via TAP.

Curiously enough, the downloaded files via the web interface don't experience the same issue, the results are not cut off at 32 char values.