fix username validator and set it as default

django-daiquiri / daiquiri

A framework for the publication of scientific databases

https://escience.aip.de/daiquiri

Apache License 2.0

26 stars 8 forks source link

fix username validator and set it as default #182

Closed kimakan closed 1 year ago

kimakan commented 1 year ago

Closes #181

TODO:

[x] add username validator allowing only small letters, numbers and underscore as default
[x] force user to change the username after the signup with a social account
[x] add more information (username) in the "Update profile"
[x] add "Terms of Use" to the form for the social account sign up

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 5540477513

3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 64.214%

Totals
Change from base Build 5483593982:	0.1%
Covered Lines:	4712
Relevant Lines:	7338

💛 - Coveralls

kimakan commented 1 year ago

Since the content of the "Terms of Use" will depend on the archive and its maintainer, it better if it's added separately for each archive. It can be done by setting

AUTH_TERMS_OF_USE = True

and creating ../templates/account/terms_of_use.html containing the text for the "Terms of Use" in the daiquiri-app. However, it might be useful to have a standard "Terms of Use" that will be used by default and the maintainer of the archive can switch it off or change the text. At least in this case, the "Terms of Use" will not be forgotten.