Closed kimakan closed 1 month ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
daiquiri/files/utils.py | 1 | 4 | 25.0% | ||
<!-- | Total: | 1 | 4 | 25.0% | --> |
Totals | |
---|---|
Change from base Build 10420115417: | -0.02% |
Covered Lines: | 4820 |
Relevant Lines: | 7535 |
Hi @kimakan , while this should work, the django way to do this would be:
from django.apps import apps
if apps.is_installed('daiquiri.stats'):
from daiquiri.stats.models import Record
...
we had a similar problem here: https://github.com/django-daiquiri/daiquiri/blob/master/daiquiri/oai/adapter.py#L365
Also, I would add that to all Record.objects.create()
.
Hi @jochenklar , thanks for the suggestion! I thought about adding this to every Record.objects.create()
but in the end, it would not solve the dependency in the migrations, so I didn't do it.
Closes #248