Update env.web to include www subdomain placeholder

django-danceschool / production-template

Django template for dance schools

5 stars 4 forks source link

Update env.web to include www subdomain placeholder #6

Closed ADubhlaoich closed 5 years ago

ADubhlaoich commented 5 years ago

See https://github.com/django-danceschool/django-danceschool/issues/117.

A placeholder for the www subdomain exists in the LetsEncrypt configuration section, but not nginx. This creates some ambiguity as it's not immediately obvious you need to manually add it yourself given the precedent of simply editing the existing placeholder variables.

It's a small detail but should help someone avoid running into the same basic problem I did.

afs2015 commented 5 years ago

This change sounds reasonable and thanks for bringing this discrepancy to our attention. Mind putting in a pull request for it?

ADubhlaoich commented 5 years ago

@afs2015 This is a pull request!

afs2015 commented 5 years ago

@ADubhlaoich: Apologizes, was looking at issues before and didn't make the context switch. I'm going to merge this in.