django-fluent / django-fluent-contents

A widget engine to display various content on Django pages
http://django-fluent.org/
Apache License 2.0
149 stars 39 forks source link

fix Django 3.0 deprecation warnings #104

Closed si14 closed 2 years ago

si14 commented 4 years ago

Hey there!

Django 3.0 brings a couple of deprecation warnings that this PR fixes.

Additionally, previous deprecation warning mechanism in placeholder_tags.py threw a warning whether it was used or not, so I adjusted it slightly to only emit the warning if a template tag is used.

codecov[bot] commented 4 years ago

Codecov Report

Merging #104 into master will decrease coverage by 0.18%. The diff coverage is 72.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
- Coverage   68.43%   68.24%   -0.19%     
==========================================
  Files         114      114              
  Lines        3795     3807      +12     
==========================================
+ Hits         2597     2598       +1     
- Misses       1198     1209      +11     
Impacted Files Coverage Δ
fluent_contents/panels.py 0.00% <0.00%> (ø)
fluent_contents/plugins/disquswidgets/models.py 0.00% <0.00%> (ø)
fluent_contents/plugins/formdesignerlink/models.py 0.00% <0.00%> (ø)
fluent_contents/plugins/twitterfeed/models.py 0.00% <0.00%> (ø)
fluent_contents/templatetags/placeholder_tags.py 58.33% <50.00%> (-41.67%) :arrow_down:
fluent_contents/utils/search.py 86.36% <80.00%> (-3.12%) :arrow_down:
fluent_contents/extensions/pluginbase.py 81.56% <100.00%> (ø)
fluent_contents/models/db.py 67.64% <100.00%> (-1.18%) :arrow_down:
fluent_contents/plugins/code/models.py 94.73% <100.00%> (ø)
fluent_contents/plugins/commentsarea/models.py 78.57% <100.00%> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc07f42...d6bdfff. Read the comment docs.

si14 commented 3 years ago

it'd be lovely to know if you are interested in this PR folks

vdboor commented 2 years ago

Hi, sorry i totally missed this PR over the year! I've merged the changes manually!

si14 commented 2 years ago

Thanks a lot!