django-fluent / django-fluent-contents

A widget engine to display various content on Django pages
http://django-fluent.org/
Apache License 2.0
149 stars 39 forks source link

PlaceholderFieldAdmin: Add positional request arg #107

Closed jayvdb closed 2 years ago

jayvdb commented 3 years ago

Closes https://github.com/django-fluent/django-fluent-contents/issues/106

codecov[bot] commented 3 years ago

Codecov Report

Merging #107 into master will decrease coverage by 0.11%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #107      +/-   ##
==========================================
- Coverage   68.43%   68.31%   -0.12%     
==========================================
  Files         114      114              
  Lines        3795     3797       +2     
==========================================
- Hits         2597     2594       -3     
- Misses       1198     1203       +5     
Impacted Files Coverage Δ
fluent_contents/admin/placeholderfield.py 87.80% <100.00%> (+0.62%) :arrow_up:
fluent_contents/rendering/utils.py 63.21% <0.00%> (-2.30%) :arrow_down:
fluent_contents/models/db.py 67.64% <0.00%> (-1.18%) :arrow_down:
fluent_contents/models/managers.py 58.26% <0.00%> (-0.87%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dc07f42...646632f. Read the comment docs.

vdboor commented 2 years ago

Thanks! Sorry for the late merge