search

django-fluent / django-fluent-contents

A widget engine to display various content on Django pages
http://django-fluent.org/
Apache License 2.0
149 stars 39 forks source link

Make cp_plugins.js grappelli-compatible #68

Closed yuriiz closed 6 years ago

yuriiz commented 8 years ago

django-grappelli does not have #content-main element in admin template which makes "Add" button on content field widget not working.

vdboor commented 8 years ago

I'd love to merge this fix, sadly this will break with django-admin-tools, which has another form at the page (for the preferences). Could you find a better way to target the proper form?

AndreiHondrari commented 6 years ago

How about adding a class like cp-form to the form and targeting it by that? Also wouldn't it by using cp-placeholderfield also for the click binds ?

codecov[bot] commented 6 years ago

Codecov Report

Merging #68 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #68   +/-   ##
=======================================
  Coverage   68.77%   68.77%           
=======================================
  Files         116      116           
  Lines        3849     3849           
=======================================
  Hits         2647     2647           
  Misses       1202     1202

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5a6d342...5f92749. Read the comment docs.