Keep dynamic form behaviour when adding fluent content items in admin

django-fluent / django-fluent-contents

A widget engine to display various content on Django pages

http://django-fluent.org/

Apache License 2.0

149 stars 39 forks source link

Keep dynamic form behaviour when adding fluent content items in admin #86

Closed jmurty closed 7 years ago

jmurty commented 7 years ago

Keep dynamic behaviour defined for content items forms or fields when adding new content items to the placeholder formset.

This is accomplished by:

using jQuery's clone(true) clone operation to copy the template including any bound events, rather than getting the raw HTML
using the Django admin's django.jQuery instance on which events were defined on page load, so the events are available to the clone operation.

This change is for https://github.com/ic-labs/django-icekit/issues/138

codecov-io commented 7 years ago

Current coverage is 58.21% (diff: 100%)

Merging #86 into master will not change coverage

@@             master        #86   diff @@
==========================================
  Files           164        164          
  Lines          4195       4195          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2442       2442          
  Misses         1753       1753          
  Partials          0          0

Powered by Codecov. Last update 0e36672...c5bea92

vdboor commented 7 years ago

Thanks a lot! Great to have this fixed!