django-ftl / fluent-compiler

High performance Python implementation of Fluent, Mozilla's l10n language
Other
21 stars 4 forks source link

Drop Support for Python 3.6 #22

Closed samylovma closed 1 year ago

samylovma commented 1 year ago

Reasons

  1. django-ftl doesn't support Python 3.6.
  2. Since 2021-12-23 Python 3.6 is EOL (see PEP 494).
  3. Type annotation improvements in Python 3.7 (see PEP 563).

Possibly changes

See also What’s New In Python 3.7.

spookylukey commented 1 year ago

If possible, I'd rather not drop Python 3.6 yet - for one thing, because fluent.runtime still supports it, and I'd like fluent-compiler to be a drop in replacement. For the level of type annotations required for #14 (i.e. user facing type annotations, rather than internals), I don't think we'll need much that is only available in Python 3.7. Is there something that can't be typed easily in Python 3.6 that we need, and is available in 3.7?

samylovma commented 1 year ago

Is there something that can't be typed easily in Python 3.6 that we need, and is available in 3.7?

No, there's nothing. In Python 3.7 added the optional feature that type annotations are not executed at runtime, which improves performance.

I agree with you! So I'm closing this issue.