search

django-getpaid / django-plans

Django application for managing account plans and quotas
MIT License
509 stars 127 forks source link

fixes for Django 4.0 #149

Closed PetrDlouhy closed 2 years ago

codecov-commenter commented 2 years ago

Codecov Report

Merging #149 (213b6a1) into master (a037347) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files           8        8           
  Lines         125      125           
=======================================
  Hits          103      103           
  Misses         22       22

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a2bdf74...213b6a1. Read the comment docs.

pandafy commented 2 years ago

Hello @PetrDlouhy! Are you still working on this?

PetrDlouhy commented 2 years ago

@pandafy Today I enabled testing in Django 4.0 and realized that the urls.py has not been yet remade to Django 4.0. That is fixed now, but there is another problem, that I will fix tomorrow.

pandafy commented 2 years ago

Thank you very much @PetrDlouhy for updating this PR promptly. .

PetrDlouhy commented 2 years ago

Now the tests are passing. I hope it is everything now.

PetrDlouhy commented 2 years ago

I added fixes of deprecation warnings, so that this hopefully runs also on Django 4.1. The future warnings would make tests fail.