search

django-getpaid / django-plans

Django application for managing account plans and quotas
MIT License
509 stars 127 forks source link

Added pending migrations #152

Closed pandafy closed 2 years ago

pandafy commented 2 years ago

Added test in CI build to avoid merging of code without migrations.

Alir3z4 commented 2 years ago

This is a good catch.

Alir3z4 commented 2 years ago

@pandafy could you please resolve the merge conflicts?

pandafy commented 2 years ago

@Alir3z4 I have rebased the PR on the current master. :)

Alir3z4 commented 2 years ago

Still merge conflicts.

Seems I've merged the other ones caused this to be in conflict again.

pandafy commented 2 years ago

@Alir3z4 I have rebased again. 😄

PetrDlouhy commented 2 years ago

@Alir3z4 Could you please approve the tests to run?

Alir3z4 commented 2 years ago

Sorry, I've missed the request to run the CI.

I've ran it and seems all the tests fail.

PetrDlouhy commented 2 years ago

The tests are probably failing because the VIES service was in some kind of error. The same commit is in #159, and the tests did run OK. Restarting them should help.

Alir3z4 commented 2 years ago

OK, rerunning them now.

Alir3z4 commented 2 years ago

You're correct, all passing. Merging now.