search

django-getpaid / django-plans

Django application for managing account plans and quotas
MIT License
509 stars 127 forks source link

fix PlanPricing.__str__() to indicate recurring pricings #170

Closed PetrDlouhy closed 2 years ago

PetrDlouhy commented 2 years ago

Small fix of __str__() in order to tell different PlanPricings apart.

codecov-commenter commented 2 years ago

Codecov Report

Merging #170 (1ecd60e) into master (18664c4) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master     #170   +/-   ##
=======================================
  Coverage   85.27%   85.27%           
=======================================
  Files          48       48           
  Lines        2221     2221           
=======================================
  Hits         1894     1894           
  Misses        327      327
Impacted Files Coverage Δ
plans/base/models.py 94.74% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 18664c4...1ecd60e. Read the comment docs.

PetrDlouhy commented 2 years ago

The tests seems to be failing because django-sequences dropped support for Django 3.0 and lower and this issue: https://github.com/django-extensions/django-extensions/issues/1743

Edit: I forgot about my own PR #169, where the django-sequences are solved. I also held back the version of django-extensions to fix the problem in that PR (which is now also part of this PR).