search

django-getpaid / django-plans

Django application for managing account plans and quotas
MIT License
509 stars 127 forks source link

replace AbstractRecurringUserPlan.has_automatic_renewal with AbstractRecurringUserPlan.renewal_triggered_by #188

Closed radekholy24 closed 6 months ago

radekholy24 commented 7 months ago

has_automatic_renewal can indicate whether the renewal is initiated by this app or by the user. However, there is no way to indicate that the renewal is initiated by another (3rd party) mechanism such as by the payment provider's server (PayPal). This new field provides such functionality while preserving has_automatic_renewal property for backward compatibility.

codecov-commenter commented 7 months ago

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.81%. Comparing base (4742b76) to head (e01a4ca).

Files Patch % Lines
plans/admin.py 83.33% 1 Missing :warning:
plans/base/models.py 95.00% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #188 +/- ## ========================================== + Coverage 86.73% 86.81% +0.07% ========================================== Files 64 65 +1 Lines 2375 2404 +29 ========================================== + Hits 2060 2087 +27 - Misses 315 317 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

PetrDlouhy commented 6 months ago

@radekholy24 Thank you very much.