search

django-nonrel / djangotoolbox

Django tools for building nonrel backends
BSD 3-Clause "New" or "Revised" License
200 stars 125 forks source link

_decode_child now leverages the Lookup API #56

Closed kavdev closed 9 years ago

kavdev commented 9 years ago

I managed to find the new location for everything except annotations. I tried self.query.get_aggregation(self.connection.alias) but that gave me a recursion error. I'm pretty sure that if an annotation isn't included in the query, it's set to true.

sethdenner commented 9 years ago

Is there a fork of this project that is more active? I would really like to get this library up to date.

aburgel commented 9 years ago

@sethdenner this looks like an incomplete pull request. there's code commented out and a comment about not knowing where to pull some data from. if you'd like it to be merged in, you could finish it off.

i would like this to be backwards compatible with previous versions of django if possible. we support 1.4-1.6 right now.

sethdenner commented 9 years ago

Awesome! Glad to know someone's listening to this thing.

I'll take over this branch and answer the outstanding questions if this has been abandoned. This solution is a lot better than the workaround I came up with to allow Django 1.7. On Apr 14, 2015 8:27 PM, "Alex Burgel" notifications@github.com wrote:

@sethdenner https://github.com/sethdenner this looks like an incomplete pull request. there's code commented out and a comment about not knowing where to pull some data from. if you'd like it to be merged in, you could finish it off.

i would like this to be backwards compatible with previous versions of django if possible. we support 1.4-1.6 right now.

Reply to this email directly or view it on GitHub https://github.com/django-nonrel/djangotoolbox/pull/56#issuecomment-93174558 .

kavdev commented 9 years ago

Hey, sorry for the absence in communication -- I've been swamped the past couple of days. I'll take a look at your changes tomorrow.

If you have any questions about my work, let me know.

From: Seth Dennermailto:notifications@github.com Sent: ‎14.‎04.‎2015 20:33 To: django-nonrel/djangotoolboxmailto:djangotoolbox@noreply.github.com Cc: Alexander Kavanaughmailto:kavanaugh.development@outlook.com Subject: Re: [djangotoolbox] _decode_child now leverages the Lookup API (#56)

Awesome! Glad to know someone's listening to this thing.

I'll take over this branch and answer the outstanding questions if this has been abandoned. This solution is a lot better than the workaround I came up with to allow Django 1.7. On Apr 14, 2015 8:27 PM, "Alex Burgel" notifications@github.com wrote:

@sethdenner https://github.com/sethdenner this looks like an incomplete pull request. there's code commented out and a comment about not knowing where to pull some data from. if you'd like it to be merged in, you could finish it off.

i would like this to be backwards compatible with previous versions of django if possible. we support 1.4-1.6 right now.

Reply to this email directly or view it on GitHub https://github.com/django-nonrel/djangotoolbox/pull/56#issuecomment-93174558 .

Reply to this email directly or view it on GitHub: https://github.com/django-nonrel/djangotoolbox/pull/56#issuecomment-93175725

aburgel commented 9 years ago

@kavdev @sethdenner can I close this PR now that #55 #62 is in progress?

sethdenner commented 9 years ago

I believe so. I didn't take all of @kavdev's commits. I left out the running 2to3 as it appears there is a sperate pull request and there was a second minor change that didn't seem within the scope of this issue.

kavdev commented 9 years ago

Closing in favor of @63.