search

django-nonrel / djangotoolbox

Django tools for building nonrel backends
BSD 3-Clause "New" or "Revised" License
201 stars 124 forks source link

2to3 #66

Open jeroenoldenburger opened 9 years ago

jeroenoldenburger commented 9 years ago

Could you please merge these 2to3 changes

kavdev commented 9 years ago

What version of python are you running? The package should work with 3.2+ as is.

jeroenoldenburger commented 9 years ago

I am running python 3.4. I get the following error:

File ".../lib/python3.4/site-packages/djangotoolbox/fields.py", line 274, in _set_model if model is not None and isinstance(self.embedded_model, basestring): NameError: name 'basestring' is not defined

Therefore i searched (and found) a fork which ran 2to3.

Maybe python-modernize might result in code which runs in both python 2 and 3

kavdev commented 9 years ago

Sorry, forgot about the other modules. #67