Raise error if order.status is unknown

[maerteijn]

I'm not really keen on the RuntimeError exception here, nor that a unknown status can occur.

[jedie]

Yeah, that's never supposed to happen. But maybe they are thinking about introducing a new status however. That's the general way I do it. I think it's better to count on the unexpected ;)

[maerteijn]

I disagree on the part to write code to count on the unexpected. When an unexpected result comes it should break.

And this sandbox application is, as I stated before, not meant to be a full blown working application but a starting point for your own project so there is no need to add a lot of safety nets here.

[vdboor]

Perhaps logger.warning(...) instead? Or raise NotImplementedError(...)?

[maerteijn]

logger.warning would make sense, so if you add that I'll merge it

[jedie]

I don't think a warning would be enough. That might quickly be overlooked, as you sayed:

When an unexpected result comes it should break.

...and a warning will not break.

And this sandbox application is [...] a starting point for your own project so there is no need to add a lot of safety nets here.

IMHO the starting point should be a good template ;)

[maerteijn]

...and a warning will not break.

You are right. Can you change it to raise the DocdataStatusException ?

[jedie]

done