django-oscar / django-oscar-docdata

Docdata Payments Gateway integration for django-oscar
Apache License 2.0
22 stars 11 forks source link

move logic from sandbox implementation ? #43

Open jedie opened 5 years ago

jedie commented 5 years ago

I think there is much needed logic in the sandbox implementation, isn't it? I think it would be good to move as much out of it as possible.

maerteijn commented 5 years ago

The sandbox application is a starting point for your own custom implementation, and used to test the oscar_docdata package. It's not there to be a fully tested reusable application.

However, I also think some of the logic in the sandbox application should be available as reusable modules. But this requires time and effort which I'm not going to spend on this project (for now). I'm already pretty happy that the project works on Python 3.x and with the Docdata 1.3 XSD.

jedie commented 5 years ago

some of the logic in the sandbox application should be available as reusable modules

That's exactly what I meant.