Added facade and interface unittests, custom DocdataMockTransport responses with set_responses

django-oscar / django-oscar-docdata

Docdata Payments Gateway integration for django-oscar

Apache License 2.0

22 stars 11 forks source link

Added facade and interface unittests, custom DocdataMockTransport responses with set_responses #54

Closed maerteijn closed 5 years ago

jedie commented 5 years ago

Great that you will implement some really needed tests ;)

What's about to implement it in a way that other can use the mockups in own project integration tests?

maerteijn commented 5 years ago

The test fixtures and the suds transport you mean? Can you specify what would be useful for reuse?

jedie commented 5 years ago

I mean everything needed to run own payment integrations tests. I copied this data into my project:

mock_suds_client() and mock_transport() from tests/conftest.py
tests/testdata/docdata_responses.py
tests/testdata/wsdl-1_3.wsdl
tests/testdata/xsd1-1_3.xsd

I can imagine that for others the pytest fixtures are also interesting. But I have my own.

Maybe it would be easiest to move the complete tests into the package. Probably into: /oscar_docdata/tests/

maerteijn commented 5 years ago

I tried moving some of the test utility code inside the package, but most of it is dependent on pytest. Which means I would have to make pytest a dependency, otherwise I'll ship code without proper dependency management. So I'll stick with this setup for now.