Add common utils - Githubissues

django-stars / backend-skeleton

108 stars 41 forks source link

Add common utils #2

Closed alexryabtsev closed 5 years ago

alexryabtsev commented 5 years ago

Add Enumeration class.
Add several helpers for Redis.
Add helper for handling media files.
Add read-only admin class and read-only tabular inline.
Add tests for added functionality.
Fix typo in startproject script.

alexryabtsev commented 5 years ago

@SergeyKubrak could you please pay extra attention to the tests. For some unknown reasons pytest-mock didn't work properly, so I've used mock from unittest instead. Is it critical?

alexryabtsev commented 5 years ago

@Quard @romanosipenko

I've updated this PR. Could you please review my changes and comments?

I did changes in a separate commit to see the difference more clearly.

Thanks.

alexryabtsev commented 5 years ago

@SergeyKubrak could you please pay extra attention to the tests. For some unknown reasons pytest-mock didn't work properly, so I've used mock from unittest instead. Is it critical?

@SergeyKubrak Up

Quard commented 5 years ago

About to do not have redis client/Enumeration/etc in skeleton I think we cat move it to snippets repo and explain to everyone how to use it. From some point of view, it is very good options as people could choose what they need/prefer.

From another point of view, most of these utils used in next Sasha's PR for user CRUD.