search

django-stars / backend-skeleton

108 stars 41 forks source link

Move django-extensions #54

Closed denys-pidlisnyi closed 3 weeks ago

denys-pidlisnyi commented 2 years ago

We use django-extensions in INSTALLED_APPS

INSTALLED_APPS = [
    # django apps
    "django.contrib.admin",
    "django.contrib.auth",
    "django.contrib.contenttypes",
    "django.contrib.sessions",
    "django.contrib.sites",
    "django.contrib.messages",
    "django.contrib.staticfiles",
    # 3rd party apps
    "rest_framework",
    "django_extensions",
    "django_filters",
    "drf_yasg",
    # our apps
    "{{ cookiecutter.project_slug }}.apps.common",
    "{{ cookiecutter.project_slug }}.apps.accounts",
] + env.list("{{ cookiecutter.project_slug | upper() }}_DEV_INSTALLED_APPS", default=[])
denys-pidlisnyi commented 2 years ago

I guess it's a copy/paste mistake.

django_extensions should not be added by default, unless you really need them in application code directly. They should be listed in DEV_INSTALLED_APPS for local development purposes.

So, the correct way to fix this issue from my perspective will be to delete this line from INSTALLED_APPS.

@zadazorg What is your opinion?

I think production environment also needs commands from this application

denys-chura commented 3 weeks ago

It seems that file changed in this PR was removed in https://github.com/django-stars/backend-skeleton/pull/73