Run CI on CircleCI - Githubissues

django-webpack / webpack-bundle-tracker

Spits out some stats about webpack compilation process to a file

MIT License

268 stars 107 forks source link

Run CI on CircleCI #100

Closed quinox closed 3 years ago

quinox commented 3 years ago

Addresses the CI discussion of #73; supersedes #95.

The CI runs against 12 (oldest still-supported LTS), LTS (14 right now) and current (16 right now). See my CircleCI for how it will look.

As can seen in this experiment the CI would have caught the problem as described in #73 .

Note! Please update the badge in README.md during merging, it's pointing to my Github right now

fjsj commented 3 years ago

Thanks @quinox , this looks great. Could you please allow me edits (check https://docs.github.com/en/github/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork)? I need it to update the badge.

quinox commented 3 years ago

I wish I knew how: I don't see the checkbox from the screenshot anywhere. The help says On user-owned forks, I made the fork in my organization, maybe that's my problem?

I've updated the badge in my repo to use django-webpack instead of ytec-nl, if you want more changes I'm guessing you can fork my repo to your personal account and modify it further there.

fjsj commented 3 years ago

yep, from orgs I think that doesn't work. no worries, that's fine, thanks. merging now