search

django-webpack / webpack-bundle-tracker

Spits out some stats about webpack compilation process to a file
MIT License
266 stars 107 forks source link

create github action workflows #113

Closed shapiromatron closed 9 months ago

JanMalte commented 1 year ago

@shapiromatron are you still working on it?

shapiromatron commented 1 year ago

I'm stuck w/ webpack4 and node18 - it looks like a common problem here: https://github.com/webpack/webpack/issues/14532

Could we updates to only support webpack5?

shapiromatron commented 1 year ago

@JanMalte I made some progress! I skipped webpack4 tests in CI and changed the base branch to the 2.0 release branch; , and got everything working except for one breaking test. The test pass suite works for me locally and no tests are skipped, but this test error looks real to me?

https://github.com/shapiromatron/webpack-bundle-tracker/actions/runs/4833291812/jobs/8613106103#step:5:23

FAIL tests/webpack5.test.js (5.767s)
  ● BundleTrackerPlugin bases tests › It should show compressed assets

    TypeError: Cannot read properties of undefined (reading 'compilation')

      11 | function testPlugin(webpack, webpackConfig, expectedResults, outputFile, done, expectErrors, expectWarnings) {
      12 |   webpack(webpackConfig, (err, stats) => {
    > 13 |     const compilationErrors = (stats.compilation.errors || []).join('\n');
         |                                      ^
      14 |     const compilationWarnings = (stats.compilation.warnings || []).join('\n');
      15 |
      16 |     expect(err).toBeFalsy();
shapiromatron commented 9 months ago

thanks for finishing this one off for me, it looks great!!!