Closed batistadasilva closed 5 months ago
@fjsj Thanks for the review
Some tests are breaking @batistadasilva Could you please check?
@fjsj It seems like there is a broken test in master
branch
The last build from 3 months ago did pass: https://github.com/django-webpack/webpack-bundle-tracker/actions/runs/7466611716 Are you seeing the same errors in localhost as well? Or in your fork?
I am seeing the same errors when running in localhost on the commit 97c7ec6
How can I help?
The error is this:
- "js/862.js",
+ "js/75.js",
Please check if this is simply a hash change. If so, you can safely change the test assertion.
Please check if this is simply a hash change.
Yes it was
@batistadasilva I think now it breaks in Webpack 4? I think it's safe to ignore sourceFilename in Webpack 4. Whoever needs to use this should upgrade, as it's not a critical feature.
@fjsj It seems like a typing error, but I don't know how to handle it
Could you help me wit this?
If assetsInfo
is undefined, you can ignore adding sourceFilename
. Like:
if (stats.compilation.assetsInfo) {
fileInfo.sourceFilename = stats.compilation.assetsInfo.get(assetName).sourceFilename;
}
@fjsj Done
However, the typing errors may still remain
@batistadasilva I see that's a tsc error, but we can ignore it on Webpack 4.
Please enable me to edit this PR: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork
Or look for a way to ignore the error TS2339 in those two lines.
Please enable me to edit this PR:
It would be with pleasure, but I couldn't find the checkbox the documentation is talking about
Or look for a way to ignore the error TS2339 in those two lines.
I don't think we can ignore a specific TS rule, so I ignored TS in both lines. I hope it's fine.
Thanks! We will release soon.
Add
sourceFilename
fieldAsset resources in
webpack-stats.json
file will look like,Related to https://github.com/django-webpack/django-webpack-loader/issues/343