search

django-wiki / django-nyt

Notification system for Django with batteries included: Email digests, user settings, JSON API
Apache License 2.0
144 stars 47 forks source link

Add support for Django 4.0. Add missing classifier for Python 3.7. #105

Closed atombrella closed 2 years ago

atombrella commented 2 years ago

@benjaoming Seems to be some permission problem with the configured SSH keys.

benjaoming commented 2 years ago

It seems that something has changed in the exit code of makemigrations? This test is simply supposed to verify that we haven't missed a migration, which we haven't.. but it exits with 1.

py38-django30 run-test: commands[0] | sh -c '! python test-project/manage.py makemigrations --dry-run --noinput'
No changes detected
ERROR: InvocationError for command /bin/sh -c '! python test-project/manage.py makemigrations --dry-run --noinput' (exited with code 1)
codecov[bot] commented 2 years ago

Codecov Report

Merging #105 (8d3d777) into main (efa5f04) will increase coverage by 0.36%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
+ Coverage   76.39%   76.76%   +0.36%     
==========================================
  Files          26       26              
  Lines         572      581       +9     
==========================================
+ Hits          437      446       +9     
  Misses        135      135
Impacted Files Coverage Δ
django_nyt/decorators.py 70.58% <100.00%> (ø)
django_nyt/tests/test_management.py 100.00% <100.00%> (ø)
django_nyt/urls.py 62.50% <100.00%> (-4.17%) :arrow_down:
django_nyt/settings.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update efa5f04...8d3d777. Read the comment docs.