search

django-wiki / django-nyt

Notification system for Django with batteries included: Email digests, user settings, JSON API
Apache License 2.0
144 stars 47 forks source link

Migrate to pytest #123

Closed benjaoming closed 10 months ago

benjaoming commented 10 months ago

In preparation for another change, I imagine needing the flexibility that's afforded by pytest.

benjaoming commented 10 months ago

@oscarmcm LMK if you have any comments here :+1: I'm aiming for a mostly "neutral" change here, but preparing for another 1.4 release with some updates :)

oscarmcm commented 10 months ago

The code looks good from my POV, but I believe you can erase the runtest.py file, if I'm not wrong, this is no longer needed.

You may also need to tweak a bit the pyproject test command, similar to what we have in wiki.

[!NOTE] I'm approving this PR as the requested changes above doesn't interfere with the purpose of this PR.

benjaoming commented 10 months ago

@oscarmcm thanks for reviewing! I wonder if you could have been looking at some kind of opposite diff since runtests.py was already deleted, and the test command in pyproject is already exactly the same that you wrote for the wiki? :)