Closed benjaoming closed 10 months ago
Attention: 2 lines
in your changes are missing coverage. Please review.
Comparison is base (
ae58eb8
) 74.30% compared to head (bcf1e7a
) 74.90%.
Files | Patch % | Lines |
---|---|---|
django_nyt/consumers.py | 0.00% | 1 Missing :warning: |
django_nyt/subscribers.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I'm gonna merge this now, not as in "this is perfect", but as in "this is the end of Chapter 1", but look forward to a sequel! The plot is unknown, but I have a good feeling we'll see some action with Django AppConfig.
Blog post: https://overtag.dk/v2/blog/a-settings-pattern-for-reusable-django-apps/
Edit: The other reason is that incidentally this PR also fixes the Read the Docs deployment that had started using the "default" Sphinx theme :scream:
This PR implements a new settings pattern that's friendly to tests using Django's
override_settings
decorator. It's also friendly to our documentation, such that we can simply render the docstrings ofdjango_nyt.settings.defaults
in order to have a nice Configuration section in our documentation.[x] Changes via suggestions and inputs from the Fediverse, including desired best-practice:
@override_settings
The reST needed to include the final documentation for the app settings:
Documentation page BEFORE:
Documentation page AFTER: