Fixed Django 1.9 {% load url from future %} compatibility issue

django-wiki / django-nyt

Notification system for Django with batteries included: Email digests, user settings, JSON API

Apache License 2.0

144 stars 47 forks source link

Closed VCAMP closed 8 years ago

VCAMP commented 8 years ago

notifymail.py now checks the Django version the user is running
If Django is > 1.9, _send_user_notifications renders a template without the deprecated {% load url from future %} tag.

benjaoming commented 8 years ago

You are very welcome to remove the {% load url from future %} entirely.. it's total legacy by now, and I don't think it should be supported.

benjaoming commented 8 years ago

And thanks for fixing :) Would you be able to implement the simpler fix?

VCAMP commented 8 years ago

Hi Ben,

You're welcome! Will do that now.

ps thank you for setting up the module in the first place!

benjaoming commented 8 years ago

Awesome!

VCAMP commented 8 years ago

Should work fine now.

benjaoming commented 8 years ago

Looks good! Thanks so much for this!