Closed kimond closed 7 years ago
Merging #35 into master will decrease coverage by
0.12%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #35 +/- ##
==========================================
- Coverage 76.08% 75.95% -0.13%
==========================================
Files 25 25
Lines 598 599 +1
==========================================
Hits 455 455
- Misses 143 144 +1
Impacted Files | Coverage Δ | |
---|---|---|
django_nyt/consumers.py | 0% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 82a28e5...2450d8a. Read the comment docs.
@benjaoming I made this quick pull request to fix a little thing about websocket connection. Should I open an issue. I didn't find the contribution guide if there is one.
Thanks @kimond for this! I wasn't aware that it was required and have only done experiments in Firefox about a year ago. Will merge and release!
Could you add a release note about it in this PR?
Yeah sure, how do I proceed to make this release note?
Hmm, actually it's okay, I realize that I will also edit it when bumping the release, so will add a note about the change :)
Thanks again!
1.04b4 is out on PyPi, am unsure about when it should be bumped to 1.0, but one could think that we are nearing the end of bugs :)
Like mentioned in the channels documentation we need to explicitly accept websocket connections in order to connect to the server. https://channels.readthedocs.io/en/stable/getting-started.html#groups