django-wiki / django-nyt

Notification system for Django with batteries included: Email digests, user settings, JSON API
Apache License 2.0
144 stars 47 forks source link

Isort configuration #76

Closed rsalmaso closed 6 years ago

rsalmaso commented 6 years ago

Added isort config and run with these rules.

codecov-io commented 6 years ago

Codecov Report

Merging #76 into master will decrease coverage by 0.12%. The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
- Coverage   75.84%   75.72%   -0.13%     
==========================================
  Files          26       26              
  Lines         559      552       -7     
==========================================
- Hits          424      418       -6     
+ Misses        135      134       -1
Impacted Files Coverage Δ
django_nyt/subscribers.py 0% <0%> (ø) :arrow_up:
django_nyt/migrations/0003_subscription.py 100% <100%> (ø) :arrow_up:
django_nyt/migrations/0005__v_0_9_2.py 100% <100%> (ø) :arrow_up:
django_nyt/tests/__init__.py 100% <100%> (ø) :arrow_up:
django_nyt/migrations/0001_initial.py 100% <100%> (ø) :arrow_up:
...jango_nyt/migrations/0002_notification_settings.py 100% <100%> (ø) :arrow_up:
django_nyt/tests/test_basic.py 100% <100%> (ø) :arrow_up:
django_nyt/management/commands/notifymail.py 73.01% <100%> (-0.43%) :arrow_down:
django_nyt/utils.py 68.42% <100%> (-3.01%) :arrow_down:
django_nyt/migrations/0006_auto_20141229_1630.py 100% <100%> (ø) :arrow_up:
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b543c15...73ab5a0. Read the comment docs.

rsalmaso commented 6 years ago

@benjaoming I'm not really sure about it but it use the same conventions in django-wiki

benjaoming commented 6 years ago

@rsalmaso seems cool, thanks - is this still WIP?

It would need some kind of linting in Travis to maintain it over time, though.

rsalmaso commented 6 years ago

No, it should be ok now.

benjaoming commented 6 years ago

Thanks! :)