search

django / asgi_ipc

IPC-based ASGI channel layer
BSD 3-Clause "New" or "Revised" License
37 stars 13 forks source link

Group could have wrong path name #1

Closed scryver closed 8 years ago

scryver commented 8 years ago

Didn't know that there couldn't be any slashes in the group path, so being extra explicit about it. Don't know if this belongs to this module or is just something I didn't know about Django Channels.

andrewgodwin commented 8 years ago

I'd prefer the check be "/" not in group, since it's a bit easier to read, but I can do that rather than making you redo the PR if you want.

scryver commented 8 years ago

Maybe it is just that it took me a while to figure out what names can and cannot be used. Not really necessary to add the assert, I agree.

andrewgodwin commented 8 years ago

It's given in the ASGI spec what names are valid: http://channels.readthedocs.io/en/latest/asgi.html

I'll modify the base asgiref class to have a validator subclasses can call that checks all those conditions.

scryver commented 8 years ago

Yes, thanks! Probably just a matter of too much information at the moment :) Nice work overall! Really useful